studio icon indicating copy to clipboard operation
studio copied to clipboard

Update Playground packages to 1.0.38 and remove the Symlink manager

Open bgrgicak opened this issue 7 months ago • 4 comments

Related issues

  • Related issues #854 #728 #548
    • https://linear.app/a8c/issue/STU-51/unable-to-resolve-symlinked-path-in-plugin-on-macos
    • https://linear.app/a8c/issue/STU-36/enable-symlinks-on-windows
    • https://linear.app/a8c/issue/STU-111/studio-symlinks-with-relative-target-paths-sometimes-dont-resolve
    • https://linear.app/a8c/issue/STU-60/studio-app-cannot-activate-wordpress-plugins-using-freemius-if-using
    • https://linear.app/a8c/issue/STU-520/studio-symlinks-with-absolute-target-paths-dont-work-on-windows

Proposed Changes

  • Update Playground packages to 1.0.38
  • Remove SymlinkManager
  • Activate Playground's followSymlinks feature
  • Remove @php-wasm/universal patch

Testing Instructions

  • Create a site in Studio
  • Symlink a plugin to the site's plugins folder
  • Confirm the plugin can be activated

Pre-merge Checklist

  • [ ] Have you checked for TypeScript, React or other console errors?

bgrgicak avatar May 22 '25 06:05 bgrgicak

ERROR in ./node_modules/@php-wasm/web/shared/icudt74l.dat 1:0
Module parse failed: Unexpected character '�' (1:0)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
(Source code omitted for this binary file)
 @ ./node_modules/@php-wasm/web/shared/icudt74l.js 1:0-42 2:0-24
 @ ./node_modules/@php-wasm/web/index.cjs 20:307-337
 @ ./node_modules/@wp-playground/blueprints/index.cjs 1:363-387
 @ ./vendor/wp-now/src/wp-now.ts 21:21-57
 @ ./vendor/wp-now/src/execute-wp-cli.ts 50:17-36
 @ ./src/lib/wp-cli-process-child.ts 13:25-68
webpack 5.94.0 compiled with 1 error and 3 warnings in 34340 ms
at cb (/opt/ci/builds/builder/automattic/studio/node_modules/@electron-forge/plugin-webpack/src/WebpackPlugin.ts:493:29)
    at finalCallback (/opt/ci/builds/builder/automattic/studio/node_modules/webpack/lib/Compiler.js:498:32)
    at /opt/ci/builds/builder/automattic/studio/node_modules/webpack/lib/Compiler.js:522:13
    at Hook.eval [as callAsync] (eval at create (/opt/ci/builds/builder/automattic/studio/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/opt/ci/builds/builder/automattic/studio/node_modules/tapable/lib/Hook.js:18:14)
    at onCompiled (/opt/ci/builds/builder/automattic/studio/node_modules/webpack/lib/Compiler.js:520:21)
    at /opt/ci/builds/builder/automattic/studio/node_modules/webpack/lib/Compiler.js:1348:17
    at eval (eval at create (/opt/ci/builds/builder/automattic/studio/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:14:1)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
🚨 Error: The command exited with status 1

bgrgicak avatar May 22 '25 06:05 bgrgicak

node_modules/@php-wasm/web/shared/icudt74l.dat the binary file is throwing a Module parse failed: Unexpected character '�' error.

bgrgicak avatar May 22 '25 06:05 bgrgicak

I will wait with merging this PR until we release Studio 1.5.2 on Monday.

bgrgicak avatar May 22 '25 08:05 bgrgicak

I will wait with merging this PR until we release Studio 1.5.2 on Monday.

Thank you, Bero!

ivan-ottinger avatar May 23 '25 15:05 ivan-ottinger

I merged this PR since we already released 1.5.2 🥳

sejas avatar May 26 '25 17:05 sejas