studio icon indicating copy to clipboard operation
studio copied to clipboard

Published 20 hours ago • verified publisher icon Automattic

I can't upload webp file into Media Library

Open wojtekn opened this issue 1 year ago • 5 comments

Quick summary

Users can't upload webp files in Studio. It looks like it doesn't work in https://playground.wordpress.net/, too.

Steps to reproduce

  1. Download webp file from https://developers.google.com/speed/webp/gallery1
  2. Create a site in Studio and open WP Admin
  3. Navigate to Media -> Add New Media File
  4. Drag the downloaded file to upload it

What you expected to happen

The file is uploaded.

What actually happened

Error is displauyed

Screenshot 2024-05-13 at 11 24 28 displayed

Impact

Most (> 50%)

Available workarounds?

Yes, easy to implement

Platform

Mac Silicon

Logs or notes

No response

wojtekn avatar May 13 '24 09:05 wojtekn

Currently, there is a workaround to upload webp files: If a user renames the file from .webp to .jpg, then the file uploads correctly and with the correct extension (webp).

This workaround works in Playground and Studio.

Screencast

Here you can see the error and the workaround:

https://github.com/Automattic/studio/assets/779993/0537b06b-2d9a-4dbd-b245-164c630563fd

sejas avatar May 13 '24 10:05 sejas

📌 REPRODUCTION RESULTS

  • Tested on Studio - Partially

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Uploading directly to the media library - fails ❌
  • Dragging into the editor - works ✅
  • Uploading through the editor via Image Block - works ✅

https://github.com/Automattic/studio/assets/14153300/e3ced420-409c-4e4f-82cc-699874455f78

📌 ACTIONS

  • Triaged

liviopv avatar May 14 '24 11:05 liviopv

Just following up on this one - it seems like WebP support in Studio would be resolved when the changes from https://github.com/WordPress/wordpress-playground/pull/1393 are published (and the @php-wasm/node dependency can be updated in Studio).

@sejas Does that sound correct? Anything else that can be done to help?

derekblank avatar May 20 '24 06:05 derekblank

Exactly! That's correct! 👌 If you want, you can ask the Playground team to release a new version. If not, I can do it tomorrow morning. Thanks!

sejas avatar May 20 '24 15:05 sejas

@derekblank , php-wasm/node has been released with v0.7.20 https://www.npmjs.com/package/@php-wasm/node 👍

sejas avatar May 21 '24 16:05 sejas

This has been fixed after updating the playground dependencies: https://github.com/Automattic/studio/pull/491 Kudos to @kozer and @jeroenpf ! 🎉

It will be available in the next Studio release.

I tested trunk, and I've been able to upload a webp image:

Screenshot 2024-09-02 at 14 21 05

sejas avatar Sep 02 '24 13:09 sejas