social-logos icon indicating copy to clipboard operation
social-logos copied to clipboard

Port over icons from Jetpack's "Social Logos" feature

Open rickcurran opened this issue 4 years ago • 4 comments

The Jetpack plugin uses "Social Logos" as a source of icons for features like its "Social Icons Widget", however, there are icons that have been added to Jetpack that are not in the main Social Logos repo (and perhaps vice-versa).

The original process was meant to be that new icons were added here in the Social Logos repo first and then pulled into Jetpack but somehow at times that process hasn't happened, so now they are out of sync.

To try and get these back in sync the two should be cross-referenced so that all icons exist in the "Social Logos".

rickcurran avatar Aug 08 '19 14:08 rickcurran

Can we have a list of the icons that we are missing?

cc @sdixon194

davewhitley avatar Jan 26 '21 19:01 davewhitley

@davewhitley sure thing! Looks like quite a few.

Here is what's included in Jetpack that's not in the repo:

  • 500px
  • Apple
  • iTunes
  • bandcamp
  • Deviantart
  • Discord
  • Digg
  • Etsy
  • Goodreads
  • Meetup
  • Ravelry
  • Slideshare
  • Snapchat
  • Soundcloud
  • Stackoverflow
  • VK
  • Yelp

Here is what's included in the repo but not in Jetpack:

  • Blogger
  • Eventbrite
  • Ghost
  • Polldaddy
  • Whatsapp
  • WooCommerce
  • Xanga

I can work on getting the latter added to Jetpack so we have parity there.

sdixon194 avatar Jan 27 '21 16:01 sdixon194

Thanks for the list! You can ignore the polldaddy one for now https://github.com/Automattic/social-logos/issues/104

davewhitley avatar Jan 27 '21 17:01 davewhitley

Sounds good! PR here:

https://github.com/Automattic/jetpack/pull/18563

sdixon194 avatar Jan 27 '21 18:01 sdixon194