Some texts are not translated

[amroland]

Some text does not translate even after running the CLI. Texts are the following:

"Contact Teacher" on Learning mode screen:

"Interactive Video - Timeline" "Interactive Video" "Interactive Video Block."

"Course Actions" icon name

"Quiz" "Evaluate progress and strengthen understanding of course concepts." "Answers" "Question Answers."

"Point" "Points"

"Break Point" "Break Point for the Interactive Video Block."

"Accordion"

PHP / WordPress / Sensei LMS version

PHP 7.4.26 WordPress 6.1.1 Sensei LMS Version: 4.9.1 | Sensei Pro Version: 1.9.1 - Sensei LMS Version: 4.15.1 | Sensei Pro Version: 1.15.1

[amroland]

I added another one: texts of "break point"

[donnapep]

Note that some of these strings are in Sensei Pro, not Sensei LMS.

[merkushin]

As for the "Contact Teacher" button, it is a normal block with a title. The title on it is translatable. But is translated at the moment of adding the block. So if the user switches language after adding the block, the title remains in the original language.

I see two ways to fix the button: 1) remove the old button and add a new one immediately; 2) just update the text on the button in the Editor.

--

At the moment, I'm looking at Interactive Block. And it looks tricky. There is a translation for the text, but is not used for some reason. So I'm looking for that reason.

[merkushin]

I was trying to find a clue why title and description are not translated in some cases, but didn't make progress. Then I noticed that core blocks are translated in the same conditions. I took a look at core blocks and found they don't use block.json at all... Here is the Video block, for example. Even though they promise that fields like title and description are localized, it doesn't work in some cases.

[merkushin]

As we could notice in that Video block, they already call the __() function.

Here is the block type switcher (Transform to), no translation function here: https://github.com/WordPress/gutenberg/blob/1d9288443b38d254092f38d0d818f96be22346ad/packages/editor/src/components/block-switcher/index.js#LL109C1-L109C1

And also no call to the translation function later in the block type list: https://github.com/WordPress/gutenberg/blob/1d9288443b38d254092f38d0d818f96be22346ad/packages/editor/src/components/block-types-list/index.js#LL74C1-L74C1

[merkushin]

Here are PR that fix title and description translations in Sensei LMS and Sensei Pro. https://github.com/Automattic/sensei/pull/6994 https://github.com/Automattic/sensei-pro/pull/2338

As for Points, I couldn't reproduce the issue. I set Russian translation for corresponding strings for "sensei-lms" and "sensei-pro" domains via Loco Translate:

[amroland]

@merkushin Only "Point" and "Points" were fixed. Every other translation are still missing. Plus now I added "Accordion", too! (Sensei LMS Version: 4.15.1 | Sensei Pro Version: 1.15.1)

[merkushin]

@amroland Glad to hear the problem with points was solved for you. As for other translations, the work is still in progress yet. Hopefully, we release them soon-ish.

[amroland]

The following texts are still not translated. (Even after running CLI):

1. Quiz block and its texts:

2. Course Actions block and its texts:

3. Accordion block and its texts (Sensei PRO):

[joashrajin]

+1 in 8157220-zd-a8c

[github-actions[bot]]

Support References

This comment is automatically generated. Please do not edit it.

• [ ] 8157220-zen

[donnapep]

Solution for this issue is documented here.

[donnapep]

Reopening this issue as we're going to have to revert the fix that we made in #7643 as it introduced a regression.

[donnapep]

Closing as we no longer need to revert this as the regression was fixed in https://github.com/Automattic/sensei/pull/7669 without affecting translations.