sensei icon indicating copy to clipboard operation
sensei copied to clipboard

LM - Video Template - Fix 0 height for video container in FSE.

Open dadish opened this issue 3 years ago • 1 comments

Fixes #5925 Fixes #5861

Changes proposed in this Pull Request

  • Fixes the height issue for Video Container block in FSE for LM Video template.
  • Fixes the alignment issue for LM template when there is no video.

Testing instructions

  • Activate LM Video template.
  • Open FSE and edit LM Video template.
  • Confirm that you see Notices, Post Content and Lesson Actions blocks below the Video Container block.
  • Visit a lesson page without Featured Video in it and confirm the top of the post content is aligned with the top of the sidebar on the right.

Screenshot / Video

Before (Frontent)

before-frontend

Before (Editor)

before-editor

After (Frontend)

after-frontend

After (Editor)

after-editor

dadish avatar Oct 13 '22 11:10 dadish

Codecov Report

Merging #5926 (e329214) into trunk (ea8b3e7) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #5926   +/-   ##
=========================================
  Coverage     44.45%   44.45%           
  Complexity     9053     9053           
=========================================
  Files           441      441           
  Lines         32411    32411           
  Branches        274      274           
=========================================
  Hits          14407    14407           
  Misses        17799    17799           
  Partials        205      205           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7cfb31d...e329214. Read the comment docs.

codecov[bot] avatar Oct 13 '22 11:10 codecov[bot]