sensei icon indicating copy to clipboard operation
sensei copied to clipboard

Removing a partial refund on order does not work.

Open StefMattana opened this issue 3 years ago • 1 comments

Reported on 5620907-zen, I was able to reproduce the issue on the user's staging site.

Steps to reproduce the issue:

  • Place an order
  • Issue a partial refund
  • Try to delete the partial refund
  • Accept confirmation pop up
  • A spinning wheel appears and never stops working
  • PHP errors below:
2022/10/10 17:31:27 [error] 213#213: *599 FastCGI sent in stderr: "PHP message: PHP Fatal error: Uncaught TypeError: Argument 1 passed to Sensei_WC_Paid_CoursesCourse_Enrolment_ProvidersWooCommerce_Simple::get_order_courses() must be an instance of WC_Order, instance of AutomatticWooCommerceAdminOverridesOrderRefund given, called in /www/oremcommx_742/public/wp-content/plugins/woothemes-sensei/plugins/sensei-pro/modules/wc-paid-courses/includes/course-enrolment-providers/class-woocommerce-simple.php on line 250 and defined in /www/oremcommx_742/public/wp-content/plugins/woothemes-sensei/plugins/sensei-pro/modules/wc-paid-courses/includes/course-enrolment-providers/class-woocommerce-simple.php:315
Stack trace:
[#0](https://woothemes.zendesk.com/agent/tickets/0) /www/oremcommx_742/public/wp-content/plugins/woothemes-sensei/plugins/sensei-pro/modules/wc-paid-courses/includes/course-enrolment-providers/class-woocommerce-simple.php(250): Sensei_WC_Paid_CoursesCourse_Enrolment_ProvidersWooCommerce_Simple->get_order_courses(Object(AutomatticWooCommerceAdminOverridesOrderRefund))
[#1](https://woothemes.zendesk.com/agent/tickets/1) /www/oremcommx_742/publ" while reading response header from upstream, client: 142.188.177.151, server: staging-oremcommx.kinsta.cloud, request: "POST /wp-admin/admin-ajax.php HTTP/1.1", upstream: "fastcgi://unix:/var/run/php7.4-fpm-oremcommx.sock:", host: "staging-oremcommx.kinsta.cloud:31273", referrer: "https://staging-oremcommx.kinsta.cloud/wp-admin/post.php?post=232285&action=edit"

Deactivating Sensei LMS Version: 4.6.3 | Sensei Pro Version: 1.6.2 fixed the issue. I also tried to update the plugin to the latest version but the issue persists. Deactivating it fixes the problem again.

StefMattana avatar Oct 13 '22 06:10 StefMattana

Support References

This comment is automatically generated. Please do not edit it.

  • [ ] 5620907-zen

github-actions[bot] avatar Oct 13 '22 06:10 github-actions[bot]

Hello, may I know in what version the fix will be delivered?

jalop123jorem avatar Oct 17 '22 11:10 jalop123jorem

Hi @jalop123jorem, it's coming in the next Sensei Pro release, 1.7.1, which should be out later this month.

yscik avatar Oct 17 '22 12:10 yscik

Hi,

Updated to 1.8, issue is still present - Can't remove partial refunds.

2022/11/04 20:40:02 [error] 194#194: *5099 FastCGI sent in stderr: "PHP message: PHP Fatal error: Uncaught TypeError: Argument 1 passed to Sensei_WC_Paid_Courses\Course_Enrolment_Providers\WooCommerce_Simple::get_order_courses() must be an instance of WC_Order, instance of Automattic\WooCommerce\Admin\Overrides\OrderRefund given, called in /www/oremcommx_742/public/wp-content/plugins/woothemes-sensei/plugins/sensei-pro/modules/wc-paid-courses/includes/course-enrolment-providers/class-woocommerce-simple.php on line 250 and defined in /www/oremcommx_742/public/wp-content/plugins/woothemes-sensei/plugins/sensei-pro/modules/wc-paid-courses/includes/course-enrolment-providers/class-woocommerce-simple.php:315

Thanks

On Mon, Oct 17, 2022 at 8:58 AM Peter Kiss @.***> wrote:

Hi @jalop123jorem https://github.com/jalop123jorem, it's coming in the next Sensei Pro release, 1.7.1, which should be out later this month.

— Reply to this email directly, view it on GitHub https://github.com/Automattic/sensei/issues/5920#issuecomment-1280821368, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASCPFKPW264KBSRICGI5HGDWDVERDANCNFSM6AAAAAARD6O2ZU . You are receiving this because you were mentioned.Message ID: @.***>

jalop123jorem avatar Nov 04 '22 20:11 jalop123jorem

Hi @jalop123jorem!

Sorry to hear that you still faced the issue! There was another method with the same problem that we fixed previously. But we already fixed the new method too (that's why this issue was automatically closed), and it's coming probably today in a new release! 😉

renatho avatar Nov 10 '22 19:11 renatho