sensei icon indicating copy to clipboard operation
sensei copied to clipboard

Published 20 hours ago • verified publisher icon Automattic

Feedback on Help Section for Sensei Home.

Open aaronfc opened this issue 3 years ago • 1 comments 

    Great! I am merging this and will work on your feedback in a separate review. Thanks!

Originally posted by @aaronfc in https://github.com/Automattic/sensei/issues/5895#issuecomment-1274839999

aaronfc avatar Oct 11 '22 15:10 aaronfc

Aarón, sorry for the late suggestion in that same PR, but I think it would be nice to add an error handler too in that fetch. Just in case the fetch fails to fail gracefully. I imagine it would be pretty simple. In assets/setup-wizard/index.js I did it using the Notice component from @wordpress/components. You could probably just add a catch to the apiFetch , and save the error in a state. Just a suggestion. :slightly_smiling_face:

Sent through slack by @renatho

aaronfc avatar Oct 12 '22 04:10 aaronfc

Closed by #5944.

github-actions[bot] avatar Oct 17 '22 12:10 github-actions[bot]