sensei icon indicating copy to clipboard operation
sensei copied to clipboard

Retrieve data from native WordPress

Open sebastienserre opened this issue 3 years ago • 1 comments

Hello,

I'm Sebastien from Polylang Pro helpdesk. We have several common customer/user and they fall in an error with Sensei LMS lessons and Polylang Pro.

We're adding in the WordPress block editor a custom metabox to allow our customer managing the CPT languages. Actually, your code is overriding default WordPress data we're using.

This PR retrieve the WordPress method to merge them with your data.

Thank you

sebastienserre avatar Oct 05 '22 08:10 sebastienserre

Codecov Report

Merging #5855 (546f8fe) into trunk (4b6d6a2) will decrease coverage by 0.00%. The diff coverage is 15.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk    #5855      +/-   ##
============================================
- Coverage     44.38%   44.37%   -0.01%     
  Complexity     9046     9046              
============================================
  Files           441      441              
  Lines         32390    32393       +3     
  Branches        274      274              
============================================
  Hits          14376    14376              
- Misses        17809    17812       +3     
  Partials        205      205              
Impacted Files Coverage Δ
includes/class-sensei-settings.php 6.94% <0.00%> (ø)
...ncludes/course-theme/class-sensei-course-theme.php 19.66% <0.00%> (-0.34%) :arrow_down:
...t-api/class-sensei-rest-api-lessons-controller.php 8.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27edc60...546f8fe. Read the comment docs.

codecov[bot] avatar Oct 05 '22 10:10 codecov[bot]

Hello @sebastienserre this is solved in the latest release. Here is the PR. Let us know if you need anything else.

gikaragia avatar Nov 01 '22 22:11 gikaragia