pocket-casts-ios
pocket-casts-ios copied to clipboard
Automattic
Edit folder screen has too many horizontal dividers
It looks to me like the Edit Folder screen has a lot of dividers. I think at least one of these could be removed (I'm looking at the two dividers between the colors and the delete button in particular), but I'm curious what @adamzelinski thinks.
Cheers for looking into this @mchowning I think it might be more the color of the dividers and the padding that is making it look a little funny. Do you mind just checking we're using $primary-ui-05 for the dividers and that the padding is correct as it looks a little tight?
Thanks!
@adamzelinski I had a look and the ThemedDivider is using the correct color:
https://github.com/Automattic/pocket-casts-ios/blob/1ed3c5b8353dcadc2cfd83fe86ca260ffe9baa99/podcasts/Styles.swift#L132-L137
It is missing padding though. Here is the current version:
and then with padding of 10 applied:
Is 10 enough, or did you have a different value in mind?
The padding looks good to me thanks @rviljoen however I think the dividers need to be the width of the screen as it looks funny with the padding on either side
The padding looks good to me thanks @rviljoen however I think the dividers need to be the width of the screen as it looks funny with the padding on either side
@adamzelinski Yes, I agree! I have removed the leading and trailing padding for the dividers:
Let me know if this is good to go and I'll submit a PR.
the dividers look really great now thanks @rviljoen however, now all the padding looks off. Can we please make sure all the text elements are in alignment. The padding from both edges should be 16pt.
@adamzelinski Sorry, I missed that! Here's my latest attempt:
In addition to fixing the padding, I also added some space between the Navigation Title ("Edit Folder") and the folder name to match your design.
Awesome, thanks @rviljoen that's looking great happy with that. I also assume that the close icon will be there too correct as it's not showing in your screenshots
@adamzelinski Yes, the close icon is visible in the app, but does not render in the Xcode view preview as it is not included in each individual view. Here is a render from the app on a real device, with the view controller rendering it:
