pocket-casts-ios icon indicating copy to clipboard operation
pocket-casts-ios copied to clipboard

Published 20 hours ago • verified publisher icon Automattic

Fixed the width and height of the download indicator in Episode cells

Open jgcaruso opened this issue 2 years ago • 0 comments

This PR fixes an iOS 14 layout issue with the width of the download indicator in Episode cells. 16px width and height constraints have been added to match other indicator icon constraints.

I spotted this issue while testing https://github.com/Automattic/pocket-casts-ios/pull/484 in iOS 14

Before After
Screenshot 2022-11-04 at 4 31 16 PM Screenshot 2022-11-04 at 4 54 27 PM

To test

  1. pull branch, build and launch in an iOS 14 simulator
  2. Start downloading an episode
  3. Return to the episodes list (Dismiss the episode view or visit Profile -> Downloads) for the podcast you downloaded an episode for
  4. The download spinner should be a square shape (not surrounded by whitespace as wide as the downloading... text)
  5. Test in an iOS 16 simulator as well to ensure no new layout issues appear

Checklist

  • [x] I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • [x] I have considered adding unit tests for my changes.
  • [ ] I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

jgcaruso avatar Nov 04 '22 20:11 jgcaruso