pocket-casts-ios icon indicating copy to clipboard operation
pocket-casts-ios copied to clipboard

Published 20 hours ago • verified publisher icon Automattic

Ensure CI deployment use SPM cache folder

Open mokagio opened this issue 2 years ago • 1 comments

Refactors Fastfile to:

  1. Remove a couple of unused lanes, :beta and :build—At least, I assume they're unused because no code runs them and they're outside of the automation work that we've been working on recently
  2. Ensures the step that builds the app for deployment in CI uses the SPM cache, as a followup to 9176e3d9bd253c382c3ca3f76d344bd8bd497315.

To test

TBD

Checklist

  • [x] I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary. – N.A.
  • [x] I have considered adding unit tests for my changes. – N.A.
  • [x] I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics. – N.A.

mokagio avatar Sep 26 '22 10:09 mokagio

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 03 '22 14:10 CLAassistant

@mokagio I was going to close this PR like https://github.com/Automattic/pocket-casts-ios/pull/363 but wasn't sure if this part was still something you wanted to do:

Remove a couple of unused lanes, :beta and :build—At least, I assume they're unused because no code runs them and they're outside of the automation work that we've been working on recently

spencertransier avatar Apr 18 '23 01:04 spencertransier

@spencertransier thank you for the ping and sorry for the late followup.

I interactive rebased the branch to keep only the minor cleanups I made and renamed the PR to reflect that.

mokagio avatar May 08 '23 03:05 mokagio