pocket-casts-ios icon indicating copy to clipboard operation
pocket-casts-ios copied to clipboard

Published 20 hours ago • verified publisher icon Automattic

UpNext on tab bar

Open SergioEstevao opened this issue 10 months ago • 4 comments

Fixes #

This PR implements the display of the UpNext on the tab bar and showing the profile link on the podcasts tab.

https://github.com/Automattic/pocket-casts-ios/assets/651601/ce5c13c3-1b0f-4716-90b3-639a1b3aaeef

Light Dark Rose
Simulator Screenshot - iPhone 15 Pro - 2024-04-14 at 14 04 38 Simulator Screenshot - iPhone 15 Pro - 2024-04-14 at 14 05 00 Simulator Screenshot - iPhone 15 Pro - 2024-04-14 at 14 05 17
Simulator Screenshot - iPhone 15 Pro - 2024-04-14 at 16 04 35 Simulator Screenshot - iPhone 15 Pro - 2024-04-14 at 16 04 18 Simulator Screenshot - iPhone 15 Pro - 2024-04-14 at 16 04 03

To test

  • Start the app
  • Ensure that the FF UpNext on the tab bar is enabled
  • Restart the app if you need to enable it
  • Check if Up Next shows on the tab on the second position
  • Tap on it
  • Check if the Up Next shows correctly and you can interact with the item correctly
  • Go to the Podcasts tab
  • Check if on the top left you see the profile icon with the user avatar ( the default avatar will be show if the user is not logged in or does not have an avatar set)
  • Tap on the profile button
  • Check that the profile view shows up by being pushed to the navigation of podcasts
  • Test the navigation to profile with this navigation
    • Open the bookmarks screens when you don't have any bookmarks, tap on headphone settings and check if it navigates correctly

Checklist

  • [x] I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • [x] I have considered adding unit tests for my changes.
  • [x] I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

When updating the spreadsheet I noticed that the format for tab events in the the [tab name]_tab_opened but on the app we are using this format [tab name]_tab_open. What is the correct one?

SergioEstevao avatar Apr 11 '24 15:04 SergioEstevao

Looking good.

I've noticed there's some transparency in the Up Next icon in the tab bar when not active, let's remove that and have all elements at the same opacity:

image

david-gonzalez-a8c avatar Apr 12 '24 13:04 david-gonzalez-a8c

@SergioEstevao

When updating the spreadsheet I noticed that the format for tab events in the the [tab name]_tab_opened but on the app we are using this format [tab name]_tab_open. What is the correct one?

tab_opened is the correct one, can you change it there?

leandroalonso avatar Apr 12 '24 14:04 leandroalonso

@leandroalonso and @david-gonzalez-a8c thanks for your reviews! It's ready for another round!

SergioEstevao avatar Apr 14 '24 15:04 SergioEstevao