pocket-casts-android icon indicating copy to clipboard operation
pocket-casts-android copied to clipboard

Stream warning notification instead of stream warning dialog unexpectedly presented

Open mchowning opened this issue 1 year ago • 0 comments

Description

Sometimes when we need to present the user a warning before streaming an episode from the full-screen player, we present the warning dialog at the bottom of the screen, and other times we present a notification warning about the stream.

It seems like we should always use the dialog when playing is initiated from the full-screen player.

Step-by-step reproduction instructions

  1. Make sure you are on a metered connection and you the warn before streaming setting turned on
  2. If you don't already have a NOT downloaded episode loaded, start playing such an episode and then pause it so that it will be loaded the next time we open the app
  3. Kill the app and reopen it
  4. Open the full screen player
  5. Tap Play
  6. 🟢 Observe the warning dialog at the bottom of the screen
  7. Tap "Stream Anyway"
  8. Tap the pause button
  9. Tap the play button
  10. 🔴 Observe that the warning notification is presented this time instead of the warning dialog

Screenshots or screen recording

Dialog Notification
image image

Did you search for existing bug reports?

  • [X] I have searched for existing bug reports.

Device, Operating system, and Pocket Casts app version

Pixel 3, Android 12, Pocket Casts 7.24-rc-1

mchowning avatar Oct 12 '22 14:10 mchowning