pocket-casts-android icon indicating copy to clipboard operation
pocket-casts-android copied to clipboard

[Project] Manage Downloaded Episodes - Display Modal when running on low storage and opening Storage & Data Use screen

Open mebarbosa opened this issue 1 year ago • 2 comments

Description

  • Displays the low storage modal when running on low storage and opening the Storage & Data Use screen
  • This PR does not implement the snooze for 7 days feature when taping on Maybe Later button
  • See: VvERCFIopLjFL8Fnczsf8r-fi-123_1167
  • Context: p1730298732804909/1730291928.354409-slack-C07TL9YK9V1

Fixes #3098

Testing Instructions

Modify the code bellow to always return true to make the tests faster. This will mock the low storage check https://github.com/Automattic/pocket-casts-android/blob/565d4f7ef92be14a27bc7cfe3c6aa6a24962a178/modules/services/utils/src/main/java/au/com/shiftyjelly/pocketcasts/utils/StorageUtil.kt#L11

  1. Download an episode
  2. Go to Profile -> Storage & Data Use
  3. ✅ Ensure the modal opens
  4. Tap on Maybe Later
  5. ✅ Ensure the modal dismiss
  6. Tap on Manage Downloads
  7. ✅ Ensure the Downloaded files screen opens

Screenshots or Screencast

Screen_recording_20241101_111721.webm

Screenshot_20241101_111138 Screenshot_20241101_111230 Screenshot_20241101_111253
light Screenshot_20241101_111057 Screenshot_20241101_111115

Checklist

  • [ ] If this is a user-facing change, I have added an entry in CHANGELOG.md
  • [x] Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • [x] I have considered whether it makes sense to add tests for my changes
  • [x] All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • [x] Any jetpack compose components I added or changed are covered by compose previews
  • [x] I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • [x] with different themes
  • [x] with a landscape orientation
  • [x] with the device set to have a large display and font size
  • [x] for accessibility with TalkBack

mebarbosa avatar Nov 01 '24 14:11 mebarbosa

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commitf079ee246d6e85ef09b6a69d0f1482de611fce5a
Direct Downloadpocketcasts-app-prototype-build-pr3149-f079ee2.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commitf079ee246d6e85ef09b6a69d0f1482de611fce5a
Direct Downloadpocketcasts-automotive-prototype-build-pr3149-f079ee2.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commitf079ee246d6e85ef09b6a69d0f1482de611fce5a
Direct Downloadpocketcasts-wear-prototype-build-pr3149-f079ee2.apk

wpmobilebot avatar Nov 01 '24 14:11 wpmobilebot

Looks great!

I just reran updateLintBaseline after uncommenting ignoreWarnings in build.gradle.

ashiagr avatar Nov 04 '24 05:11 ashiagr

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ApplicationNotResponding: Application Not Responding for at least 5000 ms. au.com.shiftyjelly.pocketcasts.player.view.Play... View Issue

Did you find this useful? React with a 👍 or 👎

sentry[bot] avatar Nov 10 '24 19:11 sentry[bot]