pocket-casts-android
pocket-casts-android copied to clipboard
Improve general settings
Description
This change improves the General settings page by removing the separators that were in the wrong place. Also, it removes the indent so the descriptions don't wrap over so many lines.
Testing Instructions
- Tap the Profile tab
- Tap the settings cog
- Tap General
- ✅ Verify the page looks right
Screenshots
| Before | After |
|---|---|
Checklist
- [ ] If this is a user-facing change, I have added an entry in CHANGELOG.md
- [ ] Ensure the linter passes (
./gradlew spotlessApplyto automatically apply formatting/linting) - [ ] I have considered whether it makes sense to add tests for my changes
- [ ] All strings that need to be localized are in
modules/services/localization/src/main/res/values/strings.xml - [ ] Any jetpack compose components I added or changed are covered by compose previews
- [ ] I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.
I have tested any UI changes...
- [ ] with different themes
- [ ] with a landscape orientation
- [ ] with the device set to have a large display and font size
- [ ] for accessibility with TalkBack
| 1 Message | |
|---|---|
| :book: | This PR is still a Draft: some checks will be skipped. |
Generated by :no_entry_sign: Danger
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
| App Name | 📱 Mobile | |
| Build Type | debugProd | |
| Commit | 30127c4c8aca5e123d0b55b1f3d688171bc46b34 | |
| Direct Download | pocketcasts-app-prototype-build-pr3146-30127c4.apk |
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
| App Name | 🚗 Automotive | |
| Build Type | debugProd | |
| Commit | 30127c4c8aca5e123d0b55b1f3d688171bc46b34 | |
| Direct Download | pocketcasts-automotive-prototype-build-pr3146-30127c4.apk |
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
| App Name | ⌚ Wear | |
| Build Type | debugProd | |
| Commit | 30127c4c8aca5e123d0b55b1f3d688171bc46b34 | |
| Direct Download | pocketcasts-wear-prototype-build-pr3146-30127c4.apk |