pocket-casts-android icon indicating copy to clipboard operation
pocket-casts-android copied to clipboard

Sync user cluster with Engage SDK

Open MiSikora opened this issue 1 year ago • 2 comments

Description

This adds user management cluster to the Engage SDK integration.

Testing Instructions

[!note] Use the Engage SDK verification app to test some parts of this.

  1. Test this with the debugProd variant.
  2. Open the app from clean installation.
  3. Minimize the app.
  4. Open the verification app and find the ENGAGEMENT_CLUSTER.
  5. Tap on the cluster.
  6. It should open the sign in screen.
  7. Verify that different analytic events for signing in use "flow": "engage_sdk" property.
  8. Sign in.
  9. Go back to the verification app.
  10. ENGAGEMENT_CLUSTER should no longer be present.
  11. Go back to the Pocket Casts app.
  12. Sign out.
  13. Go back to the verification app.
  14. ENGAGEMENT_CLUSTER should be present.

Checklist

  • [x] ~If this is a user-facing change, I have added an entry in CHANGELOG.md~
  • [x] Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • [x] I have considered whether it makes sense to add tests for my changes
  • [x] All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • [x] ~Any jetpack compose components I added or changed are covered by compose previews~
  • [x] I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • [ ] with different themes
  • [ ] with a landscape orientation
  • [ ] with the device set to have a large display and font size
  • [ ] for accessibility with TalkBack

MiSikora avatar Sep 06 '24 09:09 MiSikora

3 Warnings
:warning: View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
:warning: Class EngageSdkAccountSync is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class SignInAdapter is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by :no_entry_sign: Danger

dangermattic avatar Sep 06 '24 09:09 dangermattic

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commitc0ec0a9ef48eb8073745745b41f8485279d8b415
Direct Downloadpocketcasts-app-prototype-build-pr2807-c0ec0a9.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commitc0ec0a9ef48eb8073745745b41f8485279d8b415
Direct Downloadpocketcasts-automotive-prototype-build-pr2807-c0ec0a9.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commitc0ec0a9ef48eb8073745745b41f8485279d8b415
Direct Downloadpocketcasts-wear-prototype-build-pr2807-c0ec0a9.apk

wpmobilebot avatar Sep 06 '24 09:09 wpmobilebot

You're missing .debug app ID suffix for the debug app.

MiSikora avatar Sep 09 '24 17:09 MiSikora