pocket-casts-android
pocket-casts-android copied to clipboard
Sync user cluster with Engage SDK
Description
This adds user management cluster to the Engage SDK integration.
Testing Instructions
[!note] Use the Engage SDK verification app to test some parts of this.
- Test this with the
debugProdvariant. - Open the app from clean installation.
- Minimize the app.
- Open the verification app and find the
ENGAGEMENT_CLUSTER. - Tap on the cluster.
- It should open the sign in screen.
- Verify that different analytic events for signing in use
"flow": "engage_sdk"property. - Sign in.
- Go back to the verification app.
ENGAGEMENT_CLUSTERshould no longer be present.- Go back to the Pocket Casts app.
- Sign out.
- Go back to the verification app.
ENGAGEMENT_CLUSTERshould be present.
Checklist
- [x] ~If this is a user-facing change, I have added an entry in CHANGELOG.md~
- [x] Ensure the linter passes (
./gradlew spotlessApplyto automatically apply formatting/linting) - [x] I have considered whether it makes sense to add tests for my changes
- [x] All strings that need to be localized are in
modules/services/localization/src/main/res/values/strings.xml - [x] ~Any jetpack compose components I added or changed are covered by compose previews~
- [x] I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.
I have tested any UI changes...
- [ ] with different themes
- [ ] with a landscape orientation
- [ ] with the device set to have a large display and font size
- [ ] for accessibility with TalkBack
| 3 Warnings | |
|---|---|
| :warning: | View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity. |
| :warning: | Class EngageSdkAccountSync is missing tests, but unit-tests-exemption label was set to ignore this. |
| :warning: | Class SignInAdapter is missing tests, but unit-tests-exemption label was set to ignore this. |
Generated by :no_entry_sign: Danger
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
| App Name | 📱 Mobile | |
| Build Type | debugProd | |
| Commit | c0ec0a9ef48eb8073745745b41f8485279d8b415 | |
| Direct Download | pocketcasts-app-prototype-build-pr2807-c0ec0a9.apk |
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
| App Name | 🚗 Automotive | |
| Build Type | debugProd | |
| Commit | c0ec0a9ef48eb8073745745b41f8485279d8b415 | |
| Direct Download | pocketcasts-automotive-prototype-build-pr2807-c0ec0a9.apk |
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
| App Name | ⌚ Wear | |
| Build Type | debugProd | |
| Commit | c0ec0a9ef48eb8073745745b41f8485279d8b415 | |
| Direct Download | pocketcasts-wear-prototype-build-pr2807-c0ec0a9.apk |
You're missing .debug app ID suffix for the debug app.