pocket-casts-android icon indicating copy to clipboard operation
pocket-casts-android copied to clipboard

Convert "Customise media actions" to Compose

Open geekygecko opened this issue 5 months ago • 2 comments

Description

This change converts the "Customise media actions" page to Compose.

Testing Instructions

  • Play an episode
  • Tap on the Profile tab
  • Tap on the settings cog
  • Tap on General
  • Tap on Media notification controls
  • ✅ Pull down the notification shade and check the actions match (you might only be able to see two)
  • On the "Media notification controls" page drag to rearrange the actions
  • ✅ Pull down the notification shade and check the actions match
  • Tap on the "Show custom media actions" to disable the actions
  • ✅ Verify you can drag the actions and check the notification actions are gone

Screenshots

Before After
Screenshot_20240906_214254 Screenshot_20240906_220602
Screenshot_20240906_214310 Screenshot_20240906_220616

https://github.com/user-attachments/assets/c77cd70d-0cee-4f37-a13f-f27fef322ccf

Checklist

  • [x] If this is a user-facing change, I have added an entry in CHANGELOG.md
  • [x] Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • [x] I have considered whether it makes sense to add tests for my changes
  • [x] All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • [x] Any jetpack compose components I added or changed are covered by compose previews
  • [x] I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • [x] with different themes
  • [x] with a landscape orientation
  • [x] with the device set to have a large display and font size
  • [x] for accessibility with TalkBack

geekygecko avatar Sep 03 '24 07:09 geekygecko