pocket-casts-android icon indicating copy to clipboard operation
pocket-casts-android copied to clipboard

[Give Rating] Let the user rate a podcast that has only one episode

Open mebarbosa opened this issue 7 months ago • 0 comments

Description

  • This PR handles an edge case that the user wants to rate a podcast that has only one episode. For this case, if the user listened this episode, we will let them to rate.
  • See: p1720619863257859/1720578266.711749-slack-C077XU4GF9D

Fixes #2488

Testing Instructions

Have GIVE_RATINGS feature flag enabled

  1. Run the app
  2. Open discover
  3. Add RSS https://anchor.fm/s/f68090c0/podcast/rss that has only episode
  4. Do not listen to the episode
  5. Try to rate
  6. ✅ Ensure you can't rate
  7. Listen to the episode (scroll to almost the end)
  8. ✅ Ensure you can rate the podcast

Regression

  • Make sure the restriction still works for podcasts that has more than 1 episode: https://github.com/Automattic/pocket-casts-android/pull/2461

Checklist

  • [x] If this is a user-facing change, I have added an entry in CHANGELOG.md
  • [x] Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • [x] I have considered whether it makes sense to add tests for my changes
  • [x] All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • [x] Any jetpack compose components I added or changed are covered by compose previews
  • [x] I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • [x] with different themes
  • [x] with a landscape orientation
  • [x] with the device set to have a large display and font size
  • [x] for accessibility with TalkBack

mebarbosa avatar Jul 12 '24 15:07 mebarbosa