measure-builds-gradle-plugin icon indicating copy to clipboard operation
measure-builds-gradle-plugin copied to clipboard

Windows 10 compatibility

Open PremyslTalich opened this issue 1 year ago • 2 comments

Hello 👋, is the plugin supposed to work under windows? This line seems to break the gradle build as uname is not a Windows command.

my project build.gradle.kts

plugins {
    id("com.automattic.android.measure-builds") version "3.0.0"
}

measureBuilds {
    enable = true
}

The error I got

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'XXXXX'.
> A problem occurred starting process 'command 'uname''

Thanks for the response

PremyslTalich avatar Apr 08 '24 16:04 PremyslTalich

Ideally, we should have CI testing for Windows. However, I think it's better to use a try-catch block at least, instead of allowing the program to crash.

takahirom avatar Apr 13 '24 05:04 takahirom

hi there @PremyslTalich 👋 Thanks for the report - indeed, the plugin wasn't tested on Windows. We should support this OS as well.

@takahirom good point - I plan to add OS matrix on CI, and it'll be better to have try-catch for this 👍

wzieba avatar Apr 15 '24 07:04 wzieba