Automattic
Add support for other post types
Hi @philipjohn! I was wondering if there are any strategies in place to add this feature. Adding support for other built-in post types looks straightforward so I wanted to clarify a couple of doubts.
When adding support for other post types, should all the post types be supported by default or should there be a centralized settings page that lists all the post types available(including custom post types) and allows the user to choose which post types to support.
Hey @shantanu2704 I was actually thinking of picking this one up today.
I think that because there is no general Admin UI yet, there is no point of adding a menu item with just a single option inside ( "Support for Page post type: Yes/No" ). On top of that - when a post type is supported it'll display the Liveblog section where Liveblog has to be enabled before it will work.
As a solution, I'm thinking of just adding pages as a supported post type and applying a filter, so that anyone who wants to further extend the plugin can just add a filter to add or remove support for certain post types.
Hey @justnorris
I have already made the necessary changes to add support for pages and attachments. There isn't really much to it. Adding a filter to disable certain post types, like you are suggesting, was something I was thinking of as well. But since I am new here, I thought I would see if someone has a better idea.
Oh, that's great. In that case submit a PR so someone can look it over.
I'm not sure though about having a Liveblog for attachments. Maybe just pages and the filter? If someone needs a Liveblog for Attachments then they could use the filter.
Hey @justnorris!
I have submitted a PR( #342 ), but two tests are failing and I am not able to figure out how. If you could maybe look into it, that would be really helpful. Thanks!