kue icon indicating copy to clipboard operation
kue copied to clipboard

Convert watchStuckJobs implementation to use SCAN instead of KEYS

Open taywrobel opened this issue 7 years ago • 6 comments

Adjusts the implementation of the watchStuckJobs LUA script to use a paginated SCAN of the keyspace, rather than the current KEYS approach.

This has a significant impact in large or shared redis deployments where the keyspace can be unbounded in size. KEYS will block all execution as it runs, which can take several seconds or longer whereas the SCAN approach permits other operations to be run in between each page of results.

taywrobel avatar Apr 22 '18 16:04 taywrobel

👍 when could this be reviewd or merged?

vjustov avatar Jul 03 '18 11:07 vjustov

This is a pretty gnarly issue. Any chance this PR could get some traction?

snypelife avatar Oct 22 '18 20:10 snypelife

Last commit to master in January 2018? Don't hold your breath. @snypelife

niclic avatar Oct 22 '18 22:10 niclic

womp womp 👎

snypelife avatar Oct 23 '18 18:10 snypelife

bump

rahulroy9202 avatar Feb 14 '19 11:02 rahulroy9202

We had to cherry pick this code with modification to kue.prototype.watchStuckJobsMod

igauravsehrawat avatar Jun 10 '20 10:06 igauravsehrawat