jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

Calipsoify: Remove code that was used to redirect certain edit links to Calypso in the past

Open oskosk opened this issue 5 months ago • 2 comments

We're not setting jetpack_edit_links_calypso_redirect anymore.

This saves an unnecessary call to get_option() when Jetpack is disconnected

Proposed changes:

  • Removes code checking for jetpack_edit_links_calypso_redirect from Jetpack::__construct()
  • Removes methods Jetpack::point_edit_post_links_to_calypso and Jetpack::point_edit_comment_links_to_calypso as they are no longer used.
  • Removes file functions.wp-notif.php as it's not longer loaded

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pdWQjU-Qx-p2

Does this pull request change what data or activity we track or use?

Noe

Testing instructions:

  • Confirm there's no mention of jetpack_edit_links_calypso_redirect in dotcom, wpcomsh, or Jetpack anymore.
  • Confirm the file function.wp-notify.php is not loaded from anywhere other than the code removed in this PR
  • Confirm that the methods Jetpack::point_edit_post_links_to_calypso and Jetpack::point_edit_comment_links_to_calypso as are no longer used anywhere else.
  • Run this branch with the Jetpack Beta Tester plugin on a WoA site and check that nothing crashes.

oskosk avatar Aug 30 '24 18:08 oskosk