Dequeue the Help Center styles
The Help Center manages its own styles now. They don't need to be enqueued.
Proposed changes:
This removes the code the enqueues them.
Other information:
Should be deployed after https://github.com/Automattic/wp-calypso/pull/93628.
Testing instructions:
- cd into projects/packages/jetpack-mu-wpcom.
- Sync using pnpm run build-production-js && jetpack rsync mu-wpcom-plugin wpcom-sandbox:~/public_html/wp-content/mu-plugins/jetpack-mu-wpcom-plugin/sun (or moon).
- Go to the editor on a sandboxed site and smoke test the Help Center.
- Go to /wp-admin on a sandboxed site and smoke test the Help Center.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
-
To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the
delete/help-center-stylesbranch.- For
jetpack-mu-wpcomchanges, also adddefine( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true );to yourwp-config.phpfile.
- For
-
To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin delete/help-center-styles
Interested in more tips and information?
- In your local development environment, use the
jetpack rsynccommand to sync your changes to a WoA dev blog. - Read more about our development workflow here: PCYsg-eg0-p2
- Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2
Thank you for your PR!
When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
- :white_check_mark: Include a description of your PR changes.
- :red_circle: Add a "[Status]" label (In Progress, Needs Team Review, ...).
- :white_check_mark: Add testing instructions.
- :red_circle: Specify whether this PR includes any changes to data or privacy.
- :white_check_mark: Add changelog entries to affected projects
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:
The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.
:red_circle: Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:
## Does this pull request change what data or activity we track or use?
My PR adds *x* and *y*.
Follow this PR Review Process:
- Ensure all required checks appearing at the bottom of this PR are passing.
- Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
- For most changes, including minor cross-team impacts.
- Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
- For significant changes to core functionality.
- Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
- For complex changes or when you need extra confidence.
- Example: Refactor affecting multiple systems.
- A. Team Review: add the "[Status] Needs Team Review" label
- Get at least one approval before merging.
Still unsure? Reach out in #jetpack-developers for guidance!
Closing as not needed anymore
This PR has been marked as stale. This happened because:
- It has been inactive for the past 3 months.
- It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, etc.
If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.
If the PR is not updated (or at least commented on) in another month, it will be automatically closed.