jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

Social: Clean up media auto-conversion backend logic

Open manzoorwanijk opened this issue 1 year ago • 7 comments

Following #38497, #38499, we need to clean up the unused backend logic for auto-conversion

Proposed changes:

  • Remove the backend logic for auto-conversion

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Just do a smoke test for Social admin, Jetpack settings and Editor pages

manzoorwanijk avatar Jul 29 '24 13:07 manzoorwanijk

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/social/clean-up-media-auto-conversion-backend-logic branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/social/clean-up-media-auto-conversion-backend-logic
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/social/clean-up-media-auto-conversion-backend-logic
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions[bot] avatar Jul 29 '24 13:07 github-actions[bot]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for October 1, 2024 (scheduled code freeze on September 30, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Backup plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Boost plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Search plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Social plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Starter Plugin plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Videopress plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Migration plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Mu Wpcom plugin:

  • Next scheduled release: WordPress.com Simple releases happen daily.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

  • Next scheduled release: on demand (usually Mondays if not sooner).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Automattic For agencies client plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions[bot] avatar Jul 29 '24 13:07 github-actions[bot]

Let's ensure we test on simple and atomic sites as well for sanity.

spsiddarthan avatar Jul 31 '24 05:07 spsiddarthan

Let's ensure we test on simple and atomic sites as well for sanity.

Yes, tested on both Simple and Atomic. All good for me.

manzoorwanijk avatar Jul 31 '24 05:07 manzoorwanijk

can we put together a slightly more elaborate test plan with the different things we need to test? I can think of these, feel free to add more.

  • Classic editor/Block editor sharing a featured image to Instagram that's valid
  • Classic editor/Block editor sharing a featured image to Instagram that's invalid, but will be auto converted
  • SIG
  • Sharing social posts
  • Simple site classic vs block editor, updating both invalid and valid images for Instagram
  • Atomic sites classic vs block editor, updating both invalid and valid images for Instagram

I think that list is good enough.

manzoorwanijk avatar Aug 09 '24 04:08 manzoorwanijk

Let's test it thoroughly and ensure it's good to go.

Would be good to document the tests as a checklist on this PR and confirm at least two of us have done the tests.

This PR has the potential to break things inadvertently.

spsiddarthan avatar Aug 09 '24 08:08 spsiddarthan

I have completed the tests and all works fine for me.

  • [x] Classic editor/Block editor sharing a featured image to Instagram that's valid
  • [x] Classic editor/Block editor sharing a featured image to Instagram that's invalid, but will be auto converted
  • [x] SIG
  • [x] Sharing social posts
  • [x] Simple site classic vs block editor, updating both invalid and valid images for Instagram
  • [x] Atomic sites classic vs block editor, updating both invalid and valid images for Instagram

manzoorwanijk avatar Aug 14 '24 09:08 manzoorwanijk