Newsletters: Enhance Subscription Modal Display Logic

[lezama]

Fixes p1719421326241939/1719262060.786719-slack-C02NQ4HMJKV

Proposed changes:

• This PR introduces improvements to the logic controlling the display of the subscription modal.

Other information:

• [ ] Have you written new tests for your changes, if applicable?
• [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
• [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Go to '..'

[github-actions[bot]]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/subscribe-modal-behaviour branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/subscribe-modal-behaviour
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions[bot]]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• :white_check_mark: Include a description of your PR changes.
  
• :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• :white_check_mark: Add testing instructions.
  
• :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  
• :white_check_mark: Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for August 6, 2024 (scheduled code freeze on August 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[simison]

Intersection observer API is now has good enough support, we should use that instead; it's more performant and simpler.

I'm thinking if just relying on full page height works well in all cases, because sometimes sites have a lot of footer content too. 🤔

Some ideas:

• Use main or article HTML tag and observe scroll position only within that element, if they exist.
• Use entry-content class, which is pretty ubiquitous across themes
• Use some of the new classes coming from block templates

[simison]

@lezama when Cris is back next week, can you work with her to find good trigger point for these modals?

[lezama]

Intersection observer API is now has good enough support, we should use that instead; it's more performant and simpler.

I tried using the Intersection Observer API without success. Although it’s great for detecting when two elements intersect, it doesn’t seem straightforward for our use case. Since a post occupies the entire viewport, it always intersects at the same proportion.

[lezama]

I’ve just pushed a simplification. I believe it’s ready for testing.

cc @enejb

[lezama]

Use entry-content class, which is pretty ubiquitous across themes

it now uses .entry-content or fallbacks to document

[enejb]

I tested the change on mobile and desktop and it works really nice!