jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

Boost: Refactor Image CDN features into sub modules

Open dilirity opened this issue 1 year ago • 3 comments

Proposed changes:

  • Move Image CDN features (Liar and Quality Settings) to sub modules;
  • Add sub modules to Jetpack sync.

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Setup Boost premium and make sure LIAR and the Quality Settings work as expected.

dilirity avatar May 23 '24 09:05 dilirity

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Boost plugin:

  • Next scheduled release: July 2, 2024.
  • Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions[bot] avatar May 23 '24 09:05 github-actions[bot]

After a call with @pyronaur, I'm going to do some refactoring. Reverted this to draft.

dilirity avatar May 23 '24 16:05 dilirity

Great to see that you noticed that the Submodule looks very similar to a Module! 👍

To summarize what we talked about on the call - instead of creating a new thing called "Submodule" - what if we consider that they're all Modules anyway? We can have a special interface that marks that the Module has children (something like Has_Children or Has_Submodules) and then when setup is called, look for that interface, and if it's true - recursively call the init on each of the children too.

And to return the data, since we only need that for debug purposes anyway - create another interface called Has_Debug and use that to check if there's additional debug information that needs to be added as well.

pyronaur avatar May 23 '24 16:05 pyronaur