SSO: Add JS and CSS tooltips ** AWAITING DESIGN FEEDBACK**

[renancarvalho]

Fixes #

Proposed changes:

• Improve the tooltips by using JS and CSS instead of relying on HTML title attribute.

How it is now:

https://github.com/Automattic/jetpack/assets/2653810/0021e3bd-3284-4afa-ae0d-1f9312a0b5a3

Other information:

• [ ] Have you written new tests for your changes, if applicable?
• [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
• [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Sync this branch into your atomic site

• Navigate to /wp-admin/users.php

• Make sure you have a pending invite to be able to see the pending invite exclamation mark

• Hove over the tooltip on the table header

[github-actions[bot]]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the sso-improve-tooltips branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack sso-improve-tooltips
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions[bot]]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• :white_check_mark: Include a description of your PR changes.
  
• :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• :white_check_mark: Add testing instructions.
  
• :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  
• :white_check_mark: Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for April 2, 2024 (scheduled code freeze on April 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[crisbusquets]

From what I see on the video, it works for me. The tooltip has enough contrast and it's easy to read. Related to the accessibility concerns, does it have Aria labels (source)? I can't see it myself (the JN site I created isn't working as expected).

[agrullon95]

The new tooltip looks great and is functioning well!

One thing I noticed when using the Mac Voiceover tool is that the SSO Status column values (Connected, Pending Invite, and Send Invite) are reading out Jetpack SSO allows a seamless and secure experience on WordPress.com. Join millions of WordPress users who trust us to keep their accounts safe. before it reads out the column value.

https://github.com/Automattic/jetpack/assets/10482592/b44d3af8-1b3b-46b3-bb8c-ae7ec3b68531

[escapemanuele]

Great catch @agrullon95!

[renancarvalho]

The new tooltip looks great and is functioning well!

One thing I noticed when using the Mac Voiceover tool is that the SSO Status column values (Connected, Pending Invite, and Send Invite) are reading out Jetpack SSO allows a seamless and secure experience on WordPress.com. Join millions of WordPress users who trust us to keep their accounts safe. before it reads out the column value.

CleanShot.2024-03-06.at.15.16.29.mp4

Great @agrullon95, I made a research and spans are not selectable by tab navigation by default, I have added tabindex=0 to make them selectable and now users can understand via voice over the link and the tooltip. I think it makes sense now.

https://github.com/Automattic/jetpack/assets/2653810/196bbe0a-bbec-4bf8-9199-261e0f39c1cc

[agrullon95]

@renancarvalho - Tabbing is working much better for the actions such as Send Invite.

The only thing that seems slightly off is navigating with Control + Option and going through each row column. It usually reads out the column header name and then the column value (Name, Anthony, Role, Subscriber - something like this), but for the SSO Status column, it doesn't seem to follow this behavior.

https://github.com/Automattic/jetpack/assets/10482592/62cf2037-17b5-4cfd-aa43-5e34542179d4

Do you know anyone who can confirm what the expected accessibility behavior should be for tables?