jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

CRM: 3442 - segment performance improvements

Open tbradsha opened this issue 11 months ago • 1 comments

Resolves Automattic/zero-bs-crm#3442 - segment performance improvements

Proposed changes:

This PR allows us to use JOINs in DAL when retrieving contacts, which allows for significant speed-ups in segment retrievals.

Note that calculating listview segment totals is extremely non-performant (before and after this PR), so we disable that.

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

See Automattic/jetpack-crm-extensions#788.

tbradsha avatar Mar 05 '24 22:03 tbradsha

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

github-actions[bot] avatar Mar 05 '24 22:03 github-actions[bot]

Something is not right, in my tests the results are contradictory.

Using an identical date in both the 'Before' and 'After' fields results in 24 contacts, which should correspond to every contact linked to that product ID (55).

image

image

Yet, removing the date condition we get 32 contacts as result.

image

I will dig into this later this week.

gogdzl avatar Mar 12 '24 03:03 gogdzl