jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard
verified publisher icon Automattic

External Media: support editor changes in WordPress 6.5

Open jeherve opened this issue 1 year ago • 2 comments

Fixes #36186

Proposed changes:

Add a new conditional to ensure the External Media feature continues to work with WordPress 6.5.

This should also avoid warnings like this one:

select( 'core/edit-post' ).isInserterOpened is deprecated since version 6.5. Please use select( 'core/editor' ).isInserterOpened instead. [index.js:77:9](wp-content/plugins/gutenberg/packages/deprecated/src/index.js)

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • No

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Install the WordPress Beta Tester plugin
  • Go to Posts > Add New
  • Add a new image block
  • Pick one of the external media sources like Pexels
    • You should be able to pick an image from there.
  • Go to Tools > WordPress Beta Tester
  • Switch to Bleeding edge
  • Go to Dashboard > updates and update to a bleeding edge version of WordPress
  • Repeat your external media test to ensure the feature continues to work with WordPress 6.5.

jeherve avatar Mar 05 '24 17:03 jeherve

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for June 4, 2024 (scheduled code freeze on May 27, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions[bot] avatar Mar 05 '24 17:03 github-actions[bot]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/external-media-store branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/external-media-store

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions[bot] avatar Mar 05 '24 17:03 github-actions[bot]

I can't figure out how to get rid of the warning, TypeScript drives me a bit crazy.

@renatoagds Since you worked on #35904, do you think you could take a look? I can't figure out how to get rid of the warning when running WordPress 6.5.

Thank you!

jeherve avatar Mar 13 '24 15:03 jeherve

@jeherve sorry for the long delay here, just pushed an update, can you check if it's working for you?

renatoagds avatar May 02 '24 13:05 renatoagds

@renatoagds Thank you! This works well for me!

jeherve avatar May 06 '24 13:05 jeherve