jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard
verified publisher icon Automattic

Sharing: add Bluesky sharing button

Open jeherve opened this issue 1 year ago • 2 comments

[!NOTE] This replaces #36091

Fixes #32708 Closes #36091

Proposed changes:

This is a replay of #36091 with some fixes, since I couldn't push the fixes to the fork directly.

The PR introduces a new Bluesky sharing button, for both the legacy sharing buttons and the newer sharing buttons block.

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

Start by testing the legacy sharing buttons

  1. Go to Appearance > Themes
  2. Install and activate the Twenty Ten theme
  3. Go to wordpress.com/marketing/sharing-buttons/
  4. Add a Bluesky sharing button to your site (note that https://github.com/Automattic/wp-calypso/pull/88180, https://github.com/Automattic/wp-calypso/pull/88202, and https://github.com/Automattic/jetpack/pull/36187 will need to be merged first)
  5. After saving, it should look good on your site.
  6. Try using different button styles (official, icon, icon+text, text)
  7. Next, go to Appearance > Themes and switch to a block-based theme like Twenty Twenty Four
  8. Go to Jetpack > Settings > Sharing and disable the sharing feature.
  9. Go to Apperance > Site Editor > Templates > Single Posts
  10. Add a sharing buttons block to your template, and add a Bluesky button.
  11. Ensure it is displayed properly on the frontend, and that the button works well.

jeherve avatar Mar 05 '24 13:03 jeherve

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for April 2, 2024 (scheduled code freeze on April 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions[bot] avatar Mar 05 '24 14:03 github-actions[bot]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add-bluesky-share-button branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add-bluesky-share-button

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions[bot] avatar Mar 05 '24 16:03 github-actions[bot]

@monsieur-z Good catch! This is a problem specific to Twenty Ten. I added a fix in #36283.

jeherve avatar Mar 08 '24 10:03 jeherve

Nitpicking: in the text-only style, the text is slightly unbalanced because of a lingering margin (tested with the Twenty Ten theme).

Good catch. It looks like the margin has been around since the first version of the buttons, in f2b77b308e1df9231914615ab1f333cb3b267ad7.

I think the margin makes sense for the icon + text style, where we have an icon before the text, but it makes less sense for other button styles. I've updated things in b294eaa0b65f5da29017a9d1cebc4ec17cd60f92 Let me know what you think!

jeherve avatar Mar 11 '24 17:03 jeherve