jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

[Boost] Move styles into module stylesheets

Open thingalon opened this issue 1 year ago • 3 comments

Note: this is a fiddly task with lots of little bits. I recommend against trying to tackle it in one giant PR. Make small quick PRs over time. Another note: this is not a blocker to release.

We have styles spread across global CSS files and module files. We've decided that moving forward module files are the way to go for all but the most global-of-global things.

Here are some examples of things that can be moved into module styles:

  • https://github.com/Automattic/jetpack/pull/34599#discussion_r1434993949
  • https://github.com/Automattic/jetpack/pull/34599#discussion_r1434994431
  • https://github.com/Automattic/jetpack/pull/34599#discussion_r1434994715

But there are more.

### Tasks
- [ ] https://github.com/Automattic/jetpack/pull/35156
- [ ] https://github.com/Automattic/jetpack/pull/35516
- [ ] components/isa (part 2)
- [ ] components/button
- [ ] components/snackbar

thingalon avatar Jan 14 '24 22:01 thingalon

I am attempting this in #35104. However, the ISA styles are too tangled to modularize without risking UI bugs.

haqadn avatar Jan 18 '24 10:01 haqadn

I am attempting this in #35104. However, the ISA styles are too tangled to modularize without risking UI bugs.

Don't feel pressure to solve 100% of all cases in one go. It's ok for this to take multiple smaller PRs, and it's ok to enlist help from @pyronaur (who built the IG UI) to sort out some of the tricker cases.

thingalon avatar Jan 18 '24 23:01 thingalon

I'm splitting moving ISA components into two parts, as the first PR has gotten quite big. Moving some of the styles would require more work.

dilirity avatar Feb 08 '24 10:02 dilirity