jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard
verified publisher icon Automattic

Removed feature flag for new likes layout

Open JuanLucha opened this issue 2 years ago • 7 comments

[!CAUTION] ☢️☢️☢️ IMPORTANT: DON'T MERGE YET ☢️☢️☢️

Fixes https://github.com/Automattic/wp-calypso/issues/84422

Proposed changes:

This PR removes the feature flag for the new layout of the Likes widget.

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Not relevant

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Apply this PR
  • Connect your site through JT
  • Enable likes in Jetpack > Settings > Sharing
  • Enter your site in JT and go to a post with likes.
  • Check the iframe URL of the Likes widget. It shouldn't have any &n= parameter at all.
  • Look for another call to https://widgets.wp.com/likes/master.html in the HTML code and check that there is no &n= parameter there.

JuanLucha avatar Dec 01 '23 16:12 JuanLucha

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for March 5, 2024 (scheduled code freeze on March 4, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions[bot] avatar Dec 01 '23 16:12 github-actions[bot]

Can this be closed/abandonned?

TimBroddin avatar Jan 15 '24 08:01 TimBroddin

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the remove/likes-improvement-feature-flags branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack remove/likes-improvement-feature-flags

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions[bot] avatar Jan 23 '24 20:01 github-actions[bot]

Can this be closed/abandonned?

Hi! I have rebased with trunk and it's ready to test again.

JuanLucha avatar Jan 23 '24 20:01 JuanLucha

Works nicely with Simple, self-hosted JP and WoA sites. The proposed changes look good to me. 🙂👍🏼👍🏼

There's just one thing: the related Like block still keeps the &n=1 parameter (in projects/plugins/jetpack/extensions/blocks/like/like.php). But maybe you left in there on purpose and wanted to address it in a separate PR? 🤔

I have done the change 👍 Good catch!

JuanLucha avatar Feb 08 '24 09:02 JuanLucha

I'm sorry this has sat for so long. There's a conflict now -- if this PR is still needed, can we resolve the conflict and fast-track it for approval so it doesn't run stale again?

kraftbj avatar Apr 29 '24 14:04 kraftbj

This PR has been marked as stale. This happened because:

  • It has been inactive for the past 3 months.
  • It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, etc.

If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

If the PR is not updated (or at least commented on) in another month, it will be automatically closed.

github-actions[bot] avatar Aug 25 '24 00:08 github-actions[bot]