jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

Update site type answer text

Open CodeyGuyDylan opened this issue 3 years ago • 2 comments

Update text to conflict less with the agency/developer answer so that both can be true

Changes proposed in this Pull Request:

This PR changes the text for a site-type recommendation answer from "this is my personal site" to "this is a personal site" so that both that and "I am an agency or developer" can be true at the same time.

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

P2: p8oabR-Wd-p2#comment-6606

Does this pull request change what data or activity we track or use?

No it does not

Testing instructions:

  1. Checkout this branch and get your local environment running
  2. Go to /wp-admin/admin.php?page=jetpack#/recommendations/site-type
  3. Confirm the text has been updated image

CodeyGuyDylan avatar Sep 29 '22 18:09 CodeyGuyDylan

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: All commits were linted before commit.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team review" label and ask someone from your team review the code. Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: October 4, 2022.
  • Scheduled code freeze: September 27, 2022.

github-actions[bot] avatar Sep 29 '22 18:09 github-actions[bot]

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack update/site-type-answer-text to get started. More details: p9dueE-5Nn-p2

github-actions[bot] avatar Sep 29 '22 18:09 github-actions[bot]

cherry-picked to jetpack/branch-11.4 in 349d5f185438ef81088b76d402c18fad618556a1

samiff avatar Sep 29 '22 21:09 samiff