jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard
verified publisher icon Automattic

Jetpack Social: Add sharing limits to the editor

Open spsiddarthan opened this issue 3 years ago • 2 comments

Followup to https://github.com/Automattic/jetpack/pull/26294

Changes proposed in this Pull Request:

  • Added isShareLimitEnabled and sharesRemaining to the Jetpack_Editor_Initial_State in class.jetpack-gutenberg.php

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

p1663879658171009-slack-C02JJ910CNL

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Without the sharing limits enabled, the limits shouldn't show up.
  • Otherwise, the tests are same as the ones we have in https://github.com/Automattic/jetpack/pull/26294, except we need to do it all in Jetpack.
  • To change sharing limits, you can change it in init_sharing_limits of class-publicize-setup and tweak the value of shares_remaining. Additionally, you can change the value of sharesRemaining in projects/plugins/jetpack/extensions/plugins/publicize/components/panel/index.js
  • Additionally, if you have the blog sticker enabled and have a paid plan, the nudges shouldn't show up

spsiddarthan avatar Sep 24 '22 20:09 spsiddarthan

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :warning: All commits were linted before commit.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team review" label and ask someone from your team review the code. Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: October 4, 2022.
  • Scheduled code freeze: September 27, 2022.

Social plugin:

  • Next scheduled release: October 4, 2022.
  • Scheduled code freeze: September 26, 2022.

github-actions[bot] avatar Sep 24 '22 20:09 github-actions[bot]

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack add/sharing-limits-jetpack to get started. More details: p9dueE-5Nn-p2

github-actions[bot] avatar Sep 24 '22 20:09 github-actions[bot]

Closing this for now because of the lack of activity on this. We can always reopen in the future if needed.

jeherve avatar Jun 07 '23 16:06 jeherve