jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

Add/connection verified errors react initial state

Open chrisbliss18 opened this issue 1 year ago • 1 comments

Changes proposed in this Pull Request:

Add the connection verified errors to the connection React initial state. This is part of a bigger project (1202697549597858-as) to provide consistent failed connection error reporting and an interface to reconnect (1202697549597858-as-1202697549597864).

The changes will affect the following:

  • Jetpack
  • Connection

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

  • p9dueE-5w8-p2

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • TODO

chrisbliss18 avatar Aug 12 '22 20:08 chrisbliss18

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :warning: All commits were linted before commit.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team review" label and ask someone from your team review the code. Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: September 6, 2022.
  • Scheduled code freeze: August 30, 2022.

Backup plugin:

  • Next scheduled release: September 6, 2022.
  • Scheduled code freeze: August 29, 2022.

Boost plugin:

  • Next scheduled release: September 6, 2022.
  • Scheduled code freeze: August 29, 2022.

Search plugin:

  • Next scheduled release: September 6, 2022.
  • Scheduled code freeze: August 30, 2022.

Social plugin:

  • Next scheduled release: September 6, 2022.
  • Scheduled code freeze: August 29, 2022.

Starter Plugin plugin:

  • Next scheduled release: September 6, 2022.
  • Scheduled code freeze: August 29, 2022.

Protect plugin:

  • Next scheduled release: September 6, 2022.
  • Scheduled code freeze: August 29, 2022.

Videopress plugin:

  • Next scheduled release: September 6, 2022.
  • Scheduled code freeze: August 29, 2022.

github-actions[bot] avatar Aug 12 '22 20:08 github-actions[bot]

Hi @chrisbliss18. The code looks good, and everything works perfectly. I'm only worried that connectionVerificationErrors might imply that the errors come from some verification process, while the those are "verified" (i.e. confirmed) connection errors. May be "verified" would be a better fit, what do you think?

sergeymitr avatar Aug 19 '22 19:08 sergeymitr

Hi @chrisbliss18. The code looks good, and everything works perfectly. I'm only worried that connectionVerificationErrors might imply that the errors come from some verification process, while the those are "verified" (i.e. confirmed) connection errors. May be "verified" would be a better fit, what do you think?

Agreed. I just pushed up a change to reflect that.

chrisbliss18 avatar Aug 19 '22 19:08 chrisbliss18