jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard
verified publisher icon Automattic

Add/upload from media UI

Open leogermani opened this issue 3 years ago • 1 comments

Depends on https://github.com/Automattic/jetpack/pull/25302/

Changes proposed in this Pull Request:

  • Add REST endpoints to interact with the VideoPress uploader class
  • Implement the ability to upload a video from the Media library

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

pe4Cmx-92-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Go to Media > Add new and upload a video
  • Make sure you don't upload the video to VideoPress.
  • Create a new post
  • add a VideoPress (beta) block
  • Click Media Library
  • Select the video you just uploaded
  • Confirm you see a dialog asking you what to do:

Captura de tela de 2022-08-01 14-35-25

  • Clik Upload to VideoPress
  • Confirm you see a progress bar with the upload progress
  • When the upload finishes, the video should be embedded
  • Add a new VideoPress block
  • Click Media Library
  • Confirm that there's a new video in your library, which is the "Videopress version" of the video you just uploaded
  • Select the same video you selected the last time (the one that was uploaded to your media library)
  • Confirm you see the same dialog with a slightly different message:

Captura de tela de 2022-08-01 18-00-33

  • Click "Use VideoPress" and confirm the video is embedded right away (not uploaded)

leogermani avatar Aug 12 '22 18:08 leogermani

Caution: This PR has changes that must be merged to WordPress.com Hello leogermani! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D85893-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you! This revision will be updated with each commit to this PR

matticbot avatar Aug 12 '22 18:08 matticbot

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :warning: All commits were linted before commit.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team review" label and ask someone from your team review the code. Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: September 6, 2022.
  • Scheduled code freeze: August 30, 2022.

Videopress plugin:

  • Next scheduled release: September 6, 2022.
  • Scheduled code freeze: August 29, 2022.

github-actions[bot] avatar Aug 15 '22 20:08 github-actions[bot]

Closing in favor of https://github.com/Automattic/jetpack/pull/25792

leogermani avatar Aug 23 '22 18:08 leogermani