jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

Add/backup plan recommendation

Open jboland88 opened this issue 1 year ago • 1 comments

This PR adds a recommendation for backups into the recommendations flow. This recommendation shows up after auto-updates are enabled for a plugin on the site.

Changes proposed in this Pull Request:

  • This PR adds a new recommendation step for backups in the recommendation flow

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

pbNhbs-3jP-p2

Does this pull request change what data or activity we track or use?

This PR does not add any new events/ data. Existing events that are already in place for other recommendations will be used to track interactions with this new recommendation.

Testing instructions:

  • On your Jetpack test site, start by resetting the Jetpack options. If you are using a development version of Jetpack, this option should be available in the footer on the Jetpack Dashboard.

  • Navigate to the plugins page and click "Enable auto updates" for any of the plugins on the site. You can also toggle auto-updates off and back on for a plugin that already has the setting enabled.

  • Navigate back to the Jetpack dashboard, you should see a red "1" bade next to the "Recommendations" navigation item indicating that a new recommendation is available. Screen Shot 2022-08-10 at 11 35 56 AM

  • Click on the recommendations navigation item. You should now see the recommendation for site backups. There should be a green "New" badge showing on this step. Screen Shot 2022-08-11 at 3 46 04 PM

  • Click on the CTA to open the article in a new tab. This should link you to this post on jetpack.com: https://jetpack.com/blog/wordpress-website-backups-101/

  • Return to the tab with your test site, the recommendations flow should now be showing the summary screen. You should see "Site Backups" showing in the resources section at the bottom of the summary screen. Screen Shot 2022-08-11 at 3 46 17 PM

  • Click on the "Read More" button next to the Site Backups recommendation on the summary screen. This should take you to again to the article linked above.

  • Repeat the test using a test site that already has a Jetpack backup product or a plan that has backup features. This time, the recommendation should not be enabled after auto-updates are turned on for a plugin.

  • Confirm that any new text is properly translated.

  • Confirm that all links on the new recommendation step work and make sense.

jboland88 avatar Aug 11 '22 20:08 jboland88

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :warning: All commits were linted before commit.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team review" label and ask someone from your team review the code. Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: September 6, 2022.
  • Scheduled code freeze: August 30, 2022.

github-actions[bot] avatar Aug 11 '22 20:08 github-actions[bot]