jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

De-Fusion: Site Logo - update with wpcom specific require

Open samiff opened this issue 1 year ago • 2 comments

Changes proposed in this Pull Request:

Prerequisite wpcom-specific change for #25249

Other information:

  • [x] Have you written new tests for your changes, if applicable?
  • [x] Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

See #25249

samiff avatar Aug 02 '22 18:08 samiff

Caution: This PR has changes that must be merged to WordPress.com Hello samiff! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D85253-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you! This revision will be updated with each commit to this PR

matticbot avatar Aug 02 '22 18:08 matticbot

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: All commits were linted before commit.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team review" label and ask someone from your team review the code. Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: September 6, 2022.
  • Scheduled code freeze: August 30, 2022.

github-actions[bot] avatar Aug 02 '22 18:08 github-actions[bot]

Great news! One last step: head over to your WordPress.com diff, D85253-code, and deploy it. Once you've done so, come back to this PR and add a comment with your SVN changeset ID (e.g. r12345-wpcom).

Thank you!

github-actions[bot] avatar Aug 15 '22 16:08 github-actions[bot]

r250669-wpcom

samiff avatar Aug 15 '22 16:08 samiff