jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

Premium Content Block: User can't access premium content on renewal date.

Open rcrdortiz opened this issue 3 years ago • 2 comments

Fixes #46242

Changes proposed in this Pull Request:

  • Since we can't guarantee that the subscription renewal will happen exactly at the time of the expiry of the subscription, we now add a one-day grace period to the check that determines if the user can or can't view the premium content.

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Open a post that has premium content.
  • Create a token with a subscription that expires today.
  • Append the token to the URL.
  • You should see the content.

Test evidence:

https://user-images.githubusercontent.com/1989914/153202351-56337c4d-425e-4140-b039-33d7dfc49562.mp4

rcrdortiz avatar Feb 09 '22 12:02 rcrdortiz

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: All commits were linted before commit.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team review" label and ask someone from your team review the code. Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: July 5, 2022.
  • Scheduled code freeze: June 28, 2022.

github-actions[bot] avatar Feb 09 '22 12:02 github-actions[bot]

Waiting on https://github.com/Automattic/wp-calypso/issues/52287 to be closed

Copons avatar Jun 10 '22 10:06 Copons

Closing this for now because of the lack of activity on this. We can always reopen in the future if needed.

jeherve avatar Mar 29 '23 07:03 jeherve