fb-instant-articles icon indicating copy to clipboard operation
fb-instant-articles copied to clipboard

Published 20 hours ago • verified publisher icon Automattic

PHPCS coding standards fixes

Open paulschreiber opened this issue 7 years ago • 6 comments

This PR:

  • adds phpcs.xml.dist ruleset
  • updates composer modules
  • fixes formatting issues flagged (via phpcbf)
  • fixes or suppresses most PHPCS warnings and errors

paulschreiber avatar Nov 07 '18 03:11 paulschreiber

Merged in 4.2.0 and resolved conflicts.

paulschreiber avatar Dec 20 '18 00:12 paulschreiber

@diegoquinteiro

paulschreiber avatar Dec 20 '18 00:12 paulschreiber

@paulschreiber any reason for the filename change https://github.com/Automattic/facebook-instant-articles-wp/pull/991/commits/0475b1b61c81e1a751f80c05abcde97302b20e08 - I'm working on the GTM4WP integration and waiting on a rebase on the GTM4WP plugin before i clean this up, just just wanted to understand the change.

vincentkoc avatar Feb 01 '19 02:02 vincentkoc

@koconder This file's name didn't match the class name. (PHPCS flagged that for me.)

paulschreiber avatar Feb 01 '19 04:02 paulschreiber

@paulschreiber all good, thanks for confirming!

vincentkoc avatar Feb 01 '19 04:02 vincentkoc

Bumping PR

vincentkoc avatar Apr 06 '22 23:04 vincentkoc

Thanks all. At this point, we're not going to make coding standards changes, and the recent changes for PHP 8 have created a lot of merge conflicts, but I'm re-pointing the PR in case it's revisited in the future, and closing.

GaryJones avatar Sep 23 '22 10:09 GaryJones