fb-instant-articles icon indicating copy to clipboard operation
fb-instant-articles copied to clipboard
verified publisher icon Automattic

PHP 7.1 Compatibility

Open trepmal opened this issue 7 years ago • 1 comments

Since PHP 7.1, passing too few arguments will cause a fatal error

I've flagged two occurrences of disabled() which should pass at least one argument

  • https://github.com/Automattic/facebook-instant-articles-wp/blob/0bd3899ca4cc5e2bba212ecf30d4d8a733ba0541/wizard/class-instant-articles-option.php#L285
  • https://github.com/Automattic/facebook-instant-articles-wp/blob/0bd3899ca4cc5e2bba212ecf30d4d8a733ba0541/wizard/class-instant-articles-option.php#L359

trepmal avatar Feb 09 '18 00:02 trepmal

Is this plugin compatible with PHP 7.1 yet? Regards,

zomidaily avatar Mar 27 '18 14:03 zomidaily

Is this plugin compatible with PHP 7.1 yet?

Yes 😄 (at least the develop branch, and the first release after 5.0.0, make it so.)

GaryJones avatar Oct 15 '22 22:10 GaryJones