1 Warning & 1 Error in PHP 7

[DanielGarzaB]

Recently I installed PHP Compatibility Checker plugin to check if all my plugins where compatible with PHP 7.

Your plug in displays these Warnings/Errors:

`FILE: /var/www/site.com/public_html/wp-content/plugins/fb-instant-articles/vendor/apache/log4php/src/main/php/configurators/LoggerConfigurationAdapterXML.php

FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE

1 | WARNING | File has mixed line endings; this may cause incorrect results

FILE: /var/www/site.com/public_html/wp-content/plugins/fb-instant-articles/vendor/apache/log4php/src/examples/php/appender_socket_server.php

FOUND 1 ERROR AFFECTING 1 LINE

57 | ERROR | Function split() is deprecated since PHP 5.3 and removed since PHP 7.0; use preg_split instead

[cgidds]

Has there been any additional traction on this enhancement/feature request? We're trying to migrate to PHP7.1 and would like this (at least the error) resolved.

[pestevez]

This is not an issue that has been prioritized by our team yet.

In any case, by looking at the path to the file with the error, it looks like it is coming from the examples folder of one of our dependencies, which means that this is NOT code that we are executing. Also, we have been using the plugin on sites running PHP 7+ for a while and this has never been a problem.

I am not familiar with the PHP Compatibility Checker plugin, but per their messages:

Attention: Not all errors are show-stoppers. Test this site on PHP 7 to see if it just works!

and

This tool cannot detect unused code paths that might be used for backwards compatibility, potentially showing false positives.

The solution to this issue might be as simple as deleting the vendor/apache/log4php/src/examples in the plugin release script. CC: @diegoquinteiro

[github-actions[bot]]

This issue has been marked stale because it has been open for 30 days with no activity. If there is no activity within 7 days, it will be closed. This is an automation to keep issues manageable and actionable and is not a comment on the quality of this issue nor on the work done so far. Closed issues are still valuable to the project and are available to be searched.

[GaryJones]

Agreed that this is not a valid concern.