cli-table icon indicating copy to clipboard operation
cli-table copied to clipboard

`colors` package update would improve webpack compatibility

Open Mr-Wallet opened this issue 3 years ago • 2 comments

I'm trying to include this module in a project with webpack, which tries to gather up code into discrete bundles. It can't do this if it can't figure out where a require is likely to lead.

Older versions of colors included a setTheme method that took an arbitrary string and then tried to require that string directly, i.e. literally anything could possibly be required from literally anywhere... so webpack is in a bind. This was resolved several years ago in colors, and hopefully that dependency could be updated in the next release of cli-table.

I would have already opened a pull request myself today, but colors doesn't keep a changelog and I'm not sure how it's being used in this package, so I'm afraid of breaking something.

Mr-Wallet avatar Aug 12 '21 00:08 Mr-Wallet

Do not update colors npmjs package to >=1.4.1.

See https://security.snyk.io/vuln/SNYK-JS-COLORS-2331906

schuerg avatar Jan 10 '22 11:01 schuerg

This issue could be closed in favor of #167, which has effectively the same solution (https://github.com/Automattic/cli-table/pull/169) cc @chrean

DABH avatar Mar 24 '22 04:03 DABH