blocks-everywhere icon indicating copy to clipboard operation
blocks-everywhere copied to clipboard

Underline inline style outputs code on the front end

Open kathrynwp opened this issue 2 years ago • 11 comments

While the Underline option is provided as an inline style, it isn't displayed correctly.

To replicate

  • Select some text in a forum post
  • Click the upside-down caret icon and apply the Underline option
  • Submit the post

Result

Before submission the underlined text looks OK in the editor:

A____Would_Review_Again_-__Test_Plugin_3__Review___WordPress_org

Once submitted, inline HTML is visible on the front end:

A____Would_Review_Again_-__Test_Plugin_3__Review___WordPress_org

Expected

Underlining should be displayed on the front end instead of HTML and inline CSS.

Note

The inline options appear to be different in the live WP.org Support forums than in the test forum, which may be why this was not caught earlier. If it would be possible to get the test forum in sync with the live forum, it would be helpful.

Test Forum Inline Options

Test___WordPress_org_Testing_Rosetta

Live Forum Inline Options

Includes Justify & Underline options:

Localhost_Installs___WordPress_org

Report

Reported in Slack here

kathrynwp avatar Jan 31 '23 18:01 kathrynwp

Where are you seeing the underline option? It is not part of the plugin.

johngodley avatar Jan 31 '23 18:01 johngodley

@johngodley Weird! It's in the live forums, for example when creating a post:

https://wordpress.org/support/forum/how-to-and-troubleshooting/?view=all#new-topic-0

kathrynwp avatar Jan 31 '23 18:01 kathrynwp

It's not part of Gutenberg itself, or this plugin, so must be something added on that forum but not the test ones. If it is supposed to be there then it will need to be added to the KSES filters.

johngodley avatar Jan 31 '23 18:01 johngodley

OK! What's the best way to address this, do you think I should make a Meta ticket, or something else?

kathrynwp avatar Jan 31 '23 18:01 kathrynwp

I don't think we need underlining or justification in the forums, personally.

kathrynwp avatar Jan 31 '23 18:01 kathrynwp

Underlining may be important when users want to mimick a link without creating a real one, when paraphrasing an error message, bug or proposal. A situation which is realistic on a support forum for a CMS.

porg avatar Jan 31 '23 19:01 porg

Or when quoting text which has underlines, which is possible in Gutenberg.

Why limit expression?

porg avatar Jan 31 '23 19:01 porg

@kathrynwp I don't know what the process is, maybe @dd32 can advise. If it's not intentional then it's probably a plugin or configuration thats running on the main forums but not the test one.

johngodley avatar Jan 31 '23 19:01 johngodley

Actually, trying the wp.com editor it appears there (along with some others) so I'm guessing it's Jetpack.

johngodley avatar Jan 31 '23 19:01 johngodley

  • Could that also be the root cause for #135 ?

porg avatar Jan 31 '23 19:01 porg

Could that also be the root cause for https://github.com/Automattic/blocks-everywhere/issues/135

No. As far as I know that is now fixed.

johngodley avatar Jan 31 '23 19:01 johngodley