Gravatar-SDK-Android icon indicating copy to clipboard operation
Gravatar-SDK-Android copied to clipboard

Published 20 hours ago • verified publisher icon Automattic

QuickEditor: Refreshing all info when no avatar selected and a new one is uploaded

Open hamorillo opened this issue 4 months ago • 1 comments

Closes #380

Description

When a new avatar is uploaded into a Gravatar account with no avatar selected, the backend automatically uses that image as the default avatar.

We need to reflect that in the QE UI. We can hardcode the changes in the code, modifying the uiState as required. However, if the backend behavior changes at some point, all previous versions of the QE will show the wrong status of the Gravatar account.

To mitigate that situation, we will refresh all data from the backend if an image is uploaded and no previous avatar is selected.

What do you think about this approach? Do you think it's worth it to refresh everything or assume the risk and modify the uiState locally, expecting the backend to do the same?

Note: I'll add some unit tests before merging if we decide to go this way.

Testing Steps

  1. Using an account with no avatar selected
  2. Upload a new image using the QE
  3. Verify you see, after reloading, the new image as the selected image.

hamorillo avatar Oct 10 '24 11:10 hamorillo