Biographical Info field on contributors profile is double-encoded

[paulschreiber]

The Biographical Info (cap-description) field is double encoded. It generates HTML like this:

<label for="cap-description">Biographical Info</label></th><td>
<textarea style="width:300px;margin-bottom:6px;" name="cap-description">&amp;amp;Aaron is
here.</textarea>

In class-coauthors-guest-authors.php, in get_guest_author_fields(), we have this code:

array(
        'key'      => 'description',
        'label'    => __( 'Biographical Info', 'co-authors-plus' ),
        'group'    => 'about',
        'sanitize_function' => 'wp_filter_post_kses',
    ),

By calling wp_filter_post_kses instead of the default filter (sanitize_text_field), we end up with the double encoding.

[paulschreiber]

Here's a workaround:

foreach ( $fields as $index => $field ) {
    if ( 'description' === $field['key'] ) {
        $fields[ $index ]['sanitize_function'] = function( $s ) { return html_entity_decode( wp_filter_post_kses( $s ) ); };
    }
}```

[philipjohn]

Could you clarify where you're seeing this please? I'm assuming it's on the guest author edit screen in the "Biographical Info" textarea. Here are the steps I've taken to reproduce:

1. Create a new guest author
2. Include this in the "Biographical Info" field: Aaron is here.
3. Save the author
4. Check the textarea
5. Value is Aaron is here. as expected

[paulschreiber]

You missed the the ampersand in step 2. &Aaron is here.

This results in &Aaron is here instead of the expected &Aaron is here.

[philipjohn]

Ah that may have been a typo.

Here's what I'm typing in:

Then I hit save and see

^ That's actually after saving twice (once to add the .).

[paulschreiber]

Yup. That's the bug.

[philipjohn]

This results in &Aaron is here instead of the expected &Aaron is here.

I thought the bug was the double amp as in that ^ example?

[paulschreiber]

My original example showed the HTML source of a double-encoded ampersand (&). Your example showed the rendered version (&). We're seeing the same bug.