Automattic-Tracks-iOS

Automattic-Tracks-iOS copied to clipboard

--- Twin PR for Android: https://github.com/Automattic/Automattic-Tracks-Android/pull/206 ### Description Allow SDK consumers to specify release name or that it wants to delegate setting up release name to SDK (it's by default)....

wzieba

What says in the title. It should be okay to merge this PR as long as CI is green. --- - [x] I have considered if this change warrants release...

crazytonyli

These two tests have been regularly failing: `EventLoggingTests.testThatOnlyOneFileIsUploadedSimultaneously` `EventLoggingTests.testThatAllFilesAreEventuallyUploaded` We've added `XCTSkip`s to them for now because they don't seem to be related to any actual code changes in the...

spencertransier

In https://github.com/Automattic/Automattic-Tracks-iOS/pull/166, the PR description mentions this about `Secrets.swift`: > Create the Shared/Secrets.swift file: > - For automatticians: copy the file from our mobile secrets repo (under iOS/tracks-demo). You might...

spencertransier

The [`CrashLogging`](https://github.com/Automattic/Automattic-Tracks-iOS/blob/6ff2e444e97fed0e64a4e0030faf62a5b5054492/Sources/Remote%20Logging/Crash%20Logging/CrashLogging.swift#L11) class can be used to log any sort of event, not just crashes. Including `CrashLogging` in stack traces may cause confusion for non-fatal events:

twstokes

See @salimbraksa's comment from Jetpack and WordPress iOS: https://github.com/wordpress-mobile/WordPress-iOS/pull/20846/files#r1231271865 I could only find one usage of `logError` in the tests, and is commented: https://github.com/Automattic/Automattic-Tracks-iOS/blob/01e73975896fd63ada5b992a2dcc3acd55f90253/Tests/Tests/CrashLoggingTests.swift#L97-L114

mokagio

This PR is to address the following feedback: - [Use `OHHTTPStubs` to assert that the ExPlat assignments request contains appropriate values](https://github.com/Automattic/Automattic-Tracks-iOS/pull/253#discussion_r1179889461). - [Constrain the lifecycle of `trackService` to the test...

salimbraksa

Bumps [activesupport](https://github.com/rails/rails) from 6.1.7 to 6.1.7.3. Release notes Sourced from activesupport's releases. v6.1.7.3 Active Support Implement SafeBuffer#bytesplice [CVE-2023-28120] Active Model No changes. Active Record No changes. Action View Ignore certain...

dependabot[bot]

While working on #220, I was surprised to see `CrashLoggingDataProvider` as a `protocol` when the role it has in the code is that of a value type carrying configuration values....

mokagio

You may have noticed _some_ builds failing the macOS tests step. Emphasis on some, because this doesn't seem to be related to the code but to the agent running the...

mokagio