SirenOfShame icon indicating copy to clipboard operation
SirenOfShame copied to clipboard

Question: Plugin RequestedBy

Open jezzsantos opened this issue 9 years ago • 0 comments

I am working on the plugin for AppVeyor, and have a question about design.

When we fetch the status of our builds from the CI server we can get the username and the displayname of the person who committed the build (created the shame). i.e. Display Name: Jezz Santos, Username: jezzsantos

Now, which one should we assign to BuildStatus.RequestedBy ???

This username and displayname are coming from GitHub, because that is where we store the code, and github is what triggers the CI build. However, the username and display name of that person's SoS account may be very different. So my question is: how should we be designing whether to use the committers username or display name??

jezzsantos avatar Dec 28 '15 01:12 jezzsantos