synthesis icon indicating copy to clipboard operation
synthesis copied to clipboard

Custom Event Refactor `[AARD-2080]`

Open rutmanz opened this issue 4 months ago • 2 comments

Task

AARD-2080

Symptom

Currently there are a bunch of custom event classes with inconsistent implementations that both make it harder to find events and make the whole system more verbose. Unsubscription is also often done incorrectly or not done at all

Solution

I introduced an EventSystem class that manages all custom events and has generic create, dispatch, and listen methods.

Verification

Go through and try and trigger the list of events found in EventDataMap and confirm that they still work as before. This PR should not affect functionality


Before merging, ensure the following criteria are met:

  • [ ] All acceptance criteria outlined in the ticket are met.
  • [ ] Necessary test cases have been added and updated.
  • [ ] A feature toggle or safe disable path has been added (if applicable).
  • [ ] User-facing polish:
    • Ask: "Is this ready-looking?"
  • [ ] Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

rutmanz avatar Aug 14 '25 22:08 rutmanz

(because other open PRs add new events in ways that won't necessarily show up as conflicts, I'll want to do one last check before this is merged)

rutmanz avatar Aug 14 '25 23:08 rutmanz

Just merged dev and dealt with the conflicts

rutmanz avatar Aug 30 '25 20:08 rutmanz