synthesis icon indicating copy to clipboard operation
synthesis copied to clipboard

Quality Configuration

Open Dhruv-0-Arora opened this issue 1 year ago • 2 comments

Description

Creating a separate panel for users to configure the different graphics settings to either boost performance or enhance the graphics

JIRA Issue

Dhruv-0-Arora avatar Jul 31 '24 19:07 Dhruv-0-Arora

Hovering over the '?' icon causes a jittering behavior for me because it shifts the panel over slightly

LucaHaverty avatar Aug 07 '24 23:08 LucaHaverty

Is this PR waiting for something else to be merged in or on hold?

LucaHaverty avatar Aug 21 '24 18:08 LucaHaverty

I think it looks good. We might want to eventually make the settings tabbed rather than opening new panels with buttons but that should happen after the UI refactor. I suggested a change for a typo but other than that I think it's ready to merge.

Do we want to limit the maximum values that someone can choose? I think the upper end of the texture size values is almost impossible to run at an acceptable frame rate (especially since most people will probably be using chromebooks), so would it make sense to limit options that would tank performance like that to ones that are actually feasible to run? Especially if the settings are persisted, because it would be hard to reset the values if it takes a minute to click each button.

@PepperLola Currently I have the max shadow map size set to the renderers maxTextureSize capability, so on slower computers it will automatically limit the user. We could also manually set the value.

Screenshot 2025-06-19 at 3 39 01 PM

Dhruv-0-Arora avatar Jun 19 '25 22:06 Dhruv-0-Arora

I think it looks good except for the max texture size issues. In my experience it isn't properly limited and setting it too high can cause the app to become entirely unusable. I'm willing to leave that until later though, but I do think it should be addressed at some point.

Noted AARD-1928.

BrandonPacewic avatar Jun 20 '25 21:06 BrandonPacewic